search

Dentosal / python-sc2

A StarCraft II bot api client library for Python 3
MIT License
587 stars 182 forks source link

Class name is not consistent with naming convention #260

Open Saloshp opened 5 years ago

Saloshp commented 5 years ago

https://github.com/Dentosal/python-sc2/blob/608bd25f04e89d39cef68b40101d8e9a8a7f1634/examples/terran/onebase_battlecruiser.py#L9

Matuiss2 commented 5 years ago

What do you mean? It does follow it. https://www.python.org/dev/peps/pep-0008/#class-names

BurnySc2 commented 5 years ago

He means that the OneBaseBattleCruiserBot is called ProxyRaxBot, that would be my guess.

Saloshp commented 5 years ago

@Matuiss2, @BurnySc2 is correct, sry for the unclear description, May I open a PR for these small types of bugs?

BurnySc2 commented 5 years ago

Yes, please use the develop branch for the PRs.