search

DenverCoder1 / countdown

Website to display a countdown timer to a specified date.
http://eyl327.mywebcommunity.org/countdown/
4 stars 20 forks source link

Code cleanup #3

Open DenverCoder1 opened 3 years ago

DenverCoder1 commented 3 years ago

Can the code be cleaned up to be easier to read and more easily maintainable without removing any functionality?

Claw-Hammer commented 3 years ago

Yes, i'll try to clean up your index

MeetMangukiya7 commented 3 years ago

i would love to do this.

hareesh-pillai commented 3 years ago

Hi @DenverCoder1

As part of this ticket, I think it would be a good idea to

  1. reorganise the folder structure - i.e create separate js, css and library folders and move the countdown.js, countdownStyle.css and dayjs.min.js files into them?
  2. move the JS code in the index file to the countdown.js file?

What are your thoughts?

DenverCoder1 commented 3 years ago

@hareesh-pillai That would be great, it would definitely be a good improvement!

One thing that makes moving the JS out of the index file a bit difficult is that some PHP is inserted into the script at some points. Of course, there are ways to avoid that, though, and I still think it would be great for it to be done.

avinashchandan12 commented 2 years ago

yes i am up for this

DenverCoder1 commented 2 years ago

Hi @avinashchandan12, that would be great!

In just a few more hours it can count for Hacktoberfest :)