search

DenverCoder1 / doxygen-github-pages-action

GitHub Action for deploying Doxygen documentation to a GitHub pages branch
MIT License
75 stars 16 forks source link

feat: Enable doxygen version to be configured #30

Closed baynezy closed 2 months ago

baynezy commented 2 months ago

This makes the version of doxygen a paramter and allows the installation of versions that might not be available via apt-get.

Closes #29

DenverCoder1 commented 2 months ago

Maybe the version number could be made an input variable so the user can choose the version and it could default to a specific version. What do you think?

baynezy commented 2 months ago

@DenverCoder1 - I did think about that, I can modify the PR. give me a second.

baynezy commented 2 months ago

@DenverCoder1 - don't merge this. Making this a parameter is more fiddly. Leave it with me.

baynezy commented 2 months ago

@DenverCoder1 - so I have made the changes to make this a parameter.

Note - in my testing, I discovered that this approach only works for versions 1.9.3 and higher. Previously this action was defaulting to 1.9.1. So this might be considered a breaking change. That is your call though.

DenverCoder1 commented 2 months ago

Do you know there are significant differences between 1.9.1 and 1.9.6? If for most people, it shouldn't make a difference, it should be fine to make this a breaking change.

baynezy commented 2 months ago

There are no breaking changes according to their changelog. My code works with 1.9.1-1.12.0. I just need a capability they added in 1.9.6.

baynezy commented 2 months ago

@DenverCoder1 - is there anything more you want me to do on this?

DenverCoder1 commented 2 months ago

I will test and this should be good :+1: