search

DenverCoder1 / github-readme-streak-stats

🔥 Stay motivated and show off your contribution streak! 🌟 Display your total contributions, current streak, and longest streak on your GitHub profile README
https://streak-stats.demolab.com
MIT License
4.83k stars 750 forks source link

Streak ring overlapping the icon #211

Closed Deepakmukka1 closed 2 years ago

Deepakmukka1 commented 2 years ago

Describe the bug 2 of the themes (cobalt, onedark_duo) is not displaying as expected, the ring around the current streak over laps the fire icon

To Reproduce Steps to reproduce the behavior:

  1. Go to https://github-readme-streak-stats.herokuapp.com/demo/
  2. Click on Theme
  3. Scroll down to cobalt or onedark_duo
  4. See error

Expected behavior The icon should come above the ring creating an effect like this

image

Screenshots Current behavior

image

Desktop (please complete the following information):

DenverCoder1 commented 2 years ago

It seems to be an issue with all transparent themes (cobalt and all themes ending with _duo)

Using the background color behind the fire to mask out part of the ring isn't going to work if the background is transparent.

A different way of masking out the ring is likely required. The fix for this will probably also fix #151.

DenverCoder1 commented 2 years ago

The issue should be fixed now. I expected it to be more difficult than it was.

Let me know if there are still any issues.