DenverCoder1 / github-readme-streak-stats

🔥 Stay motivated and show off your contribution streak! 🌟 Display your total contributions, current streak, and longest streak on your GitHub profile README
https://streak-stats.demolab.com
MIT License
4.82k stars 750 forks source link

Let commits to PR increase contribution streak #431

Closed Ishaan2053 closed 1 year ago

Ishaan2053 commented 1 year ago

Is your feature request related to a problem?

When commits are made to existing Pull Requests, the card doesn't count it as a contribution while GitHub contribution squares turn green under similar circumstances, counting it as a contribution.

Describe the solution you'd like To make the stats card count these commits as contribution to make it in line with how GitHub counts contributions.

Describe alternatives you've considered none 🙂

Additional context


The card doesn't show the commit to existing PRs as a contribution (New streak starts from 23, breaking the previous one despite a contribution on 22 January) image


Official GitHub squares count it as a valid contribution though (Day of contribution highlighted is 22 January 2023) image

DenverCoder1 commented 1 year ago

I can't change how it's calculated since I am getting the contribution count data directly from GitHub.

GitHub does not count commits in pull requests until they are merged into a main or gh-pages branch.

See here for the details of how contributions are counted: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-profile/managing-contribution-settings-on-your-profile/why-are-my-contributions-not-showing-up-on-my-profile

If the contributions are in private repos, make sure to enable the setting for counting contributions in private repos. If the issue is with timezones, the only solution is to modify or add commits to fill in the gap (see https://github.com/DenverCoder1/github-readme-streak-stats/blob/main/docs/faq.md#why-doesnt-my-streak-stats-match-my-contribution-graph)

Ishaan2053 commented 1 year ago

Well, I went through it and I see there's nothing we can do about it. I'm closing this issue as resolved