search

DenverCoder1 / readme-typing-svg

⚡ Dynamically generated, customizable SVG that gives the appearance of typing and deleting text for use on your profile page, repositories, or website.
https://readme-typing-svg.demolab.com
MIT License
5.4k stars 841 forks source link

Use inherited colors for svg text #283

Closed jahirfiquitiva closed 1 month ago

jahirfiquitiva commented 6 months ago

Is your feature request related to a problem? Please describe.

Since we can have/use light and dark themes, the generated SVG colors might not always have a color with enough contrast.

Describe the solution you'd like

Make the SVG use the inherited color by default (i.e. if no specific color is set in the URL). This can be done with css and the inherit or currentColor properties.

DenverCoder1 commented 6 months ago

That doesn't work when the svg is used through an img tag, styling features do not get applied.

You can use special markup to make different versions for dark mode and light mode, though - https://github.com/DenverCoder1/readme-typing-svg/blob/main/docs/faq.md#how-do-i-make-different-svgs-for-dark-mode-and-light-mode

jahirfiquitiva commented 6 months ago

thanks for the suggestion @DenverCoder1 😀🙌