Denvi / Candle

GRBL controller application with G-Code visualizer written in Qt.
GNU General Public License v3.0
1.37k stars 547 forks source link

Abort and Pause (under the gcode window) in Candle 1.2 #541

Open pad73 opened 2 years ago

pad73 commented 2 years ago

Versions

I found in Candle 1.2 some different behaviour of the buttons Abort and Pause. In Candle 1.1. after click on the button action was immeditatelly, when click on Pause then program stop (HOLD), when click on Abort program stop and terminate immeditatelly. BUT In 1.2 (15) version after clicking on both these buttons program continue with actually loaded data and goes to the pause or stop after moving by these last datas. It means there is long time between click and action. It is very uncomfortable and may be, little dangerous. Only way with pause is to use HOLD button (that is OK, it works perfectly). But to terminate program imediatelly the way is only one, RESET. Not so good because it means loosing working coordinates. Of course you can put it back using stored coordinates using G92. But as I wrote before, it is very uncomfortable.

And I found that reaction to click on moving buttons (x y z) is slower than Candle 1.1

Can anybody explain it? Is it any settings to change buttons behaviour?

Now, when I´m writing this text I have idea to use shortcuts because there is possibility to add shortcut to Hold and Abort, but I can test it just now. Otherwise if it will work I will use it, but original buttons funciton will stay strange to me.

pad73 commented 2 years ago

Yesterday I tested function of Pause and Abort using shortcuts ... works the same as when using buttons. This is not acceptable for me so I´m leaving 1.2 version, and I´m going back to 1.1. This 1.2 version brings some new nice tools (scripts, working area borders, ...), but changed more important thing to unusable. If anybody has solution let me know please.

rjcamatos commented 2 years ago

O think it is something about cache cuue, you need to wait until last cache finish then it will pause! To emergency stop push button cancel.

A quarta, 16/03/2022, 08:50, pad73 @.***> escreveu:

Yesterday I tested function of Pause and Abort using shortcuts ... works the same as when using buttons. This is not acceptable for me so I´m leaving 1.2 version, and I´m going back to 1.1. This 1.2 version brings some new nice tools (scripts, working area borders, ...), but changed more important thing to unusable. If anybody has solution let me know please.

— Reply to this email directly, view it on GitHub https://github.com/Denvi/Candle/issues/541#issuecomment-1068878162, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZXGNYVW4KUEBNEEVGWHGTVAGOERANCNFSM5QYKRLQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

pad73 commented 2 years ago

You wrote nothing new, but how to solve it? It seems to me the base code for Candle 1.2 was reprogramed to use some new functions and it brings these issues.

mar0x commented 2 years ago

Can anybody explain it?

According to source code, the "Pause" button in "Experimental" branch (v 1.2) changes the sender state i.e. affects only commands from the file to send. The commands which was sent are processed by CNC as usual. This why you experience the delay before CNC stops. As far as I understand, the "Hold" button was introduced exactly to immediately pause the CNC (source).

In stable version (v 1.1), the "Pause" send to CNC "!" character processed by CNC right as "Hold" button in v 1.2.

The "Abort" button in "Experimental" branch (v 1.2) just enqueue "M2" command. So CNC will process the commands which was already sent and then stop. Again, with delay. The "Reset" button in "Experimental" branch (v 1.2) does the actions similar to "Abort" in stable version.

Is it any settings to change buttons behaviour?

I can't see in source code the way to change it's behaviour. Just use "Hold" button to immediately pause CNC. Regarding "Reset" behaviour difference, could you confirm the difference in v1.1 "Abort" and v1.2 "Reset" button result?

pad73 commented 2 years ago

Thank you for explaining. Hold is Ok, there isn't problem. But to use reset as abort program isn't the best way IMHO.

mar0x commented 2 years ago

"Reset" in v1.2 does exactly the same as "Abort" in v1.1: send "soft-reset" command. I've tested - machine and work coordinates remains unchanged. Could you please confirm it?

This is the question to @Denvi what is the purpose of new "Pause" and "Abort" in v1.2 ?

pad73 commented 2 years ago

Thank for your answer. I will test it evening. I used it yet but it looks strange to me. But OK, I will test it again focused on.

pad73 commented 2 years ago

Sorry for my English 😉 https://youtu.be/mM8WeGjbDXs

mar0x commented 2 years ago

Thank you for video! The difference is obvious.

I'm sorry, I was wrong about equivalence of "Abort" in 1.1 and "Reset" in 1.2. This is not true.

"Abort" in 1.1 immediately send "!" (which is the same as "Pause" in 1.1 or "Hold" in 1.2) and m_aborting flag raised. The only way to send "!" in 1.2 is "Hold" button.

"Reset" button in "Control" panel should behave same way in 1.1 and 1.2.

pad73 commented 2 years ago

Result of it is that isn't cool ... It is quite stupid

mar0x commented 2 years ago

Sad but true. Consider following sequence for "Abort":

  1. "Halt" for immediate stop the machine (remember work coordinates to check);
  2. "Reset" (in "Control" panel) to stop processing file;
  3. "Restore Origin" to restore work coordinates (check the restored coordinates from the step 1);

Agree, this is not as simple as one button click, but should work.

Maybe @Denvi can suggest something different...

pad73 commented 2 years ago

Easy way - let it works as before 😉

SinkaGit commented 7 months ago

Could you please fix this?