search

Denvi / Candle

GRBL controller application with G-Code visualizer written in Qt.
GNU General Public License v3.0
1.34k stars 548 forks source link

New fork, refactor, does it make sense? #632

Open etet100 opened 3 months ago

etet100 commented 3 months ago

Hi. I wanted to add some minor functionality, and after reviewing the code I ended up STARTING to rewrite much of it from scratch. But at some stage I came to the conclusion that it might not make sense.

So a question, mainly to people who have created/create forks of the Candle app themselves. In your opinion, does it make sense to rebuild it completely? The idea is to build it modularly, separate the UI from the logic (to allow easy switching of different UIs) and actually rewrite much of the code.

I wonder if you would see something in such a project that would make you abandon your own forks in favor of such a refactored version. And most importantly - would you be willing to add something from yourselves to such a version?

barkermn01 commented 2 months ago

Actually, at that stage, you're not forking for a merge but rather undertaking a complete rewrite, which means that none of the work others are currently doing can be merged in, thus defeating the purpose of using git.

The optimal approach would be to initiate a new git repository from scratch and transfer over the necessary code, ensuring that your license and README.md files acknowledge this project. Additionally, your new project must also be licensed under GPLv3, as this is a stipulation of the GPL V3 License employed by this software.

etet100 commented 2 months ago

Actually, I don't think that's quite what I meant. I never planned to merge it to the original (dead) Candle. It was more about the point of creating a new app at all. And I know that the work already done will not necessarily be easy to merge into my fork. But still, someone may feel like doing it.

mar0x commented 2 months ago

Hello, Although it's a matter of wording, I would rather said the project is "suspend" :) We all use it, fork it, patch it, try to contribute with PR. There are not too much users who want and able (at the same time) to maintain Candle.

etet100 commented 2 months ago

You know... hundreds of open issues, dozens of PRs. For me, it's more than "suspended." And because of this, X forks were created. That's why I was wondering if it's worth rewriting it (which I'm already doing) and making sure the project lives.

mar0x commented 2 months ago

In case of Candle issues means people (still) using it and PRs means people tries to improve it. I agree it would be nice to have someone who continue to maintain it, fix issues, accept and review PRs..

All above does not mean you should not rewrite it. I wonder you asking this question in a "dead Candle" issue :)

Consider to review existing forks list here, maybe you find something useful for your project.

barkermn01 commented 2 months ago

My whole thing was a make a copy not a fork, because your repo's compatibility with this repos code base will be shot from what you have made sound like a very good idea.