Closed nuomizai closed 2 years ago
@nuomizai all our test showed that legacy is not needed. Looks like Franka Cabinet was missing. Ill return back legacy schedule.
HI @nuomizai I can confirm that legacy is better in this env. Not that much but trains faster. Created pr. https://github.com/Denys88/rl_games/pull/185
Hi, @Denys88 . I saw an appearant performance drop during training with the latest rl_games version, the reward picture is as follows (trained with the FrankaCabinet Environment in IsaacGymEnvs):
The orange line is training with the latest version and the blue one is with the old version (v1.4.0). I found that the latest code in
a2c_common.py
, there is noself.schedule_type
, and all scheduler updates as the way whenself.schedule_type=='standard'
. The latest code is as follows:When I changed the code as follows
Then the performance is as before.
So, why you choose to remove the selection of self.scheduler_type? Will it be better when you set the default
self.schedule_type='legacy'
as before?