player.determenistic misspelling

Denys88 / rl_games

RL implementations

MIT License

848 stars 142 forks source link

player.determenistic misspelling #187

Closed etaoxing closed 2 years ago

etaoxing commented 2 years ago

"deterministic" is currently misspelled as "determenistic": https://github.com/Denys88/rl_games/blob/1a890971d462c6dc7d632432377b0fc26509ae37/rl_games/common/player.py#L45

A few of the cfgs in IsaacGymEnvs (ex.) and OmniIsaacGymEnvs (ex.) use deterministic: True, but this shouldn't affect them since the default value is True.

Might be a good idea to accept both "deterministic" and "determenistic" for backwards compatibility.

Denys88 commented 2 years ago

@etaoxing thanks for the report. Fixed it here: https://github.com/Denys88/rl_games/pull/188 I'll run a few tests and merge it.