search

Denys88 / rl_games

RL implementations
MIT License
941 stars 155 forks source link

Fix setuptools #190

Closed jacarvalho closed 2 years ago

Denys88 commented 2 years ago

hi, @jacarvalho why did you decide to close pr?

jacarvalho commented 2 years ago

Hi @Denys88, I accidentally opened the pr in your repo instead of in my fork. Afterwards I could not find quickly an option to delete the pr. However, FYI we had to include setuptools in the toml file to install rl_games without an issue - as in here https://github.com/Denys88/rl_games/pull/190/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711

Sorry for the confusion.

Denys88 commented 2 years ago

thanks for the explanation!