Denys88 / rl_games

RL implementations
MIT License
848 stars 142 forks source link

some suggestions for rl-games #194

Open ankurhanda opened 2 years ago

ankurhanda commented 2 years ago
Denys88 commented 2 years ago

thanks @ankurhanda and @ArthurAllshire for the feedbacks. I finally got free weekend :) 1) Masking - will be implemented 2) what do you mean by arbitrary nerworks? It is possible to create custom neural network right now. Here is example in my custom branch with transformers and neural network from the OpenAI paper: https://github.com/Denys88/IsaacGymEnvs/blob/main/isaacgymenvs/learning/networks/ig_networks.py 3) We can try but not sure it will work. I found that it is very hard to learn something meaningful in LSTM and if we corrupt it I believe we will just help NN to learn to ignore states. 4) Could you clarify. It might be more IG side issue. 5) I have plans to implement unittests. Also it would be nice to see more tests in IG too :)