Closed JuryA closed 3 months ago
At the same time, you are trying to solve a real issue as pointed out in the issue, but I would prefer a new PR that don't use the bitnami dependency.
I have created a new PR, #20, and have incorporated all the points we discussed therein.
Important changes:
_helpers.tpl
, including documentation where necessary. (@nscuro)ingress.yaml
by removing the detection of the K8s API version and other related components. (@NissesSenap)extraDeploy.yaml
template as a universal option for adding extra K8s resources for advanced users (which includes documentation for contributors).May I ask to close this PR as a duplicate?
Enhancements to Ingress Configuration in the Dependency-Track Helm Chart
🛠 Changes
values.yaml
file, allowing users to dynamically customize Ingress settings such as annotations, TLS secrets, and hostnames.values.yaml
andREADME.md
files to guide users on configuring the Ingress resource, emphasizing the new parameters and their impacts.🧪 How to Test
📝 Notes
Close #17