DeployHubProject / DeployHub-Pro

DeployHub Pro Pipeline Status Project
https://www.openmakesoftware.com/application-release-automation-for-continuous-delivery/
Other
11 stars 4 forks source link

scripts not executing with custom action #305

Closed piyush94 closed 4 years ago

piyush94 commented 4 years ago

Working fine with Pre and Post Action. With Custom Action getting below error:

image

Procedures: image

and

image

CC: @svisagan83

sbtaylor15 commented 4 years ago

@piyush94 it looks like the custom action is pushing an additional environment variable that isn't valid for the shell, ?customcomp117=Y. Let us do some debugging on this since we have logic in place to avoid this. Need to figure out how that variable is being passed to the shell.

CC: @svisagan83

sbtaylor15 commented 4 years ago

@piyush94 we updated dmtransfer to exclude vars with ? from being passed to the remote shell.

From:

            value = line.split("=", 1)[-1]
            remote_env[key] = value

To:

            value = line.split("=", 1)[-1]
            if ("?" not in key):
                remote_env[key] = value

Latest image has the update.

CC: @svisagan83

piyush94 commented 4 years ago

@sbtaylor15 thanks, it's working now.

CC: @svisagan83