DeployHubProject / DeployHub-Pro

DeployHub Pro Pipeline Status Project
https://www.openmakesoftware.com/application-release-automation-for-continuous-delivery/
Other
11 stars 4 forks source link

application and component versioning issue #326

Closed piyush94 closed 3 years ago

piyush94 commented 3 years ago

Continuing upon #325 , consider this scenario, when we create a few versions of an application or component from UI and then delete an in-between version of either application or component, the parent version of subsequent versions is not set correctly and the chain of versions is lost. This causes various issues going forward.

sbtaylor15 commented 3 years ago

Fixed the reparenting on a delete for the app version and comp version.

Image ui-skin-v9.0.0.3090-gd18917f and master-v9.0.0.2939-g2cba1b0 and going forward have the updates in place. Fyi, same images as the API updates for the Groovy changes.

piyush94 commented 3 years ago

Tried tag, master-v9.0.0.2940-g22a4259. The issue is still there.

sbtaylor15 commented 3 years ago

Which one did not work, deleting a component version, app version or both.

piyush94 commented 3 years ago

I only tried deleting an application version.

sbtaylor15 commented 3 years ago

Can you send a screen shot of your version tree for the base application? We need to see how the versions are related to each other.

sbtaylor15 commented 3 years ago

You can skip the screen shot. We believe that we found what is happening. There are multiple ways to delete the version in the old UI and they each call a different method on the backend.

sbtaylor15 commented 3 years ago

Here is the image with the update master-v9.0.0.2941-ga4d91ba. Looks like only the old UI had this issue. Components versions in the old UI had the same issue. Fixed as well.

piyush94 commented 3 years ago

Thanks, it's working for both application and component versions.