DeploymentResearch / DRFiles

Sample files for the Deployment Research Blog
MIT License
358 stars 322 forks source link

Update Config-DisableWindowsStoreUpdates.wsf #14

Closed eduardomozart closed 4 years ago

eduardomozart commented 6 years ago

Allow Enabling Windows Store Updates into an On-line OS.

LipkeGu commented 5 years ago

Are you sure it is the correct file?! You have changed the "Disabke" but your changes are more suiteable in the "Enable" file.

https://github.com/DeploymentResearch/DRFiles/blob/9152996d551515190436bb7d7c0006c3845d6047/Scripts/Config-DisableWindowsStoreUpdates.wsf#L1

arwidmark commented 5 years ago

I have uploaded a new file to https://github.com/DeploymentResearch/DRFiles/blob/master/Scripts/Config-DisableWindowsStoreUpdates.wsf

LipkeGu commented 5 years ago

https://github.com/DeploymentResearch/DRFiles/blob/master/Scripts/Config-DisableWindowsStoreUpdates.wsf#L15

https://github.com/DeploymentResearch/DRFiles/blob/master/Scripts/Config-DisableWindowsStoreUpdates.wsf#L45

Line 15: There is an overlook from Line 45.

arwidmark commented 5 years ago

Thanks, fixed the typo.

LipkeGu commented 5 years ago

In this Script and as i see you fixed it here but not in your other scripts… like Disable Cortana... im Always see a line like:

UpdateDevicePath = Success

Did we Need this or is it a bug?

https://github.com/DeploymentResearch/DRFiles/blob/9152996d551515190436bb7d7c0006c3845d6047/Scripts/Config-DisableWindowsStoreUpdates.wsf#L34

sanchezjei commented 4 years ago

Is this change correct? Should it be deleting the registry keys rather than changing their values? The language on lines 42 and 57 indicate that it's meant to "Enable" instead of "Disable"...

eduardomozart commented 4 years ago

If you use Config-DisableWindowsStoreUpdates.wsf to disable Windows Store updates after installing Windows 10 (e.g. to avoid it installing windows store apps after installing Windows 10 through MDT - a process that can take a while, delaying the deploy process), it will set the keys that my script deletes. So my script only has the feature to re-enable windows store updates deleting the keys that was set by Config-DisableWindowsStoreUpdates.wsf. Deleting the keys restore the default behavior from Windows 10, that is download windows store updates. You can set a task that runs my script after deploying Windows 10.