search

DeqingSun / ch55xduino

An Arduino-like programming API for the CH55X
GNU Lesser General Public License v2.1
433 stars 85 forks source link

comment bug #38

Closed nerdralph closed 3 years ago

nerdralph commented 3 years ago

You have the endpoint comments backwards. The first one is OUT, 2nd one is IN. https://github.com/DeqingSun/ch55xduino/blob/ch55xduino/ch55xduino/ch55x/libraries/Generic_Examples/examples/05.USB/CMSIS_DAP/src/CMSIS_DAPusb/USBconstant.c#L47

bEndpointAddress bit 7 direction 0 = Out, 1 = In

I fixed it and cleaned up the descriptors a bit more in my version. https://github.com/nerdralph/ch554_sdcc/blob/master/examples/CMSIS_DAP/USBconstant.c#L55

DeqingSun commented 3 years ago

Thanks for pointing out. Fixed in https://github.com/DeqingSun/ch55xduino/commit/36d05a5ca3c3ad16f79e3f47cfc98fb93a3fec82