Der1248 / Labyrinthus

1 stars 1 forks source link

Game overwrites global Minetest settings #8

Open Wuzzy2 opened 1 month ago

Wuzzy2 commented 1 month ago

The game overwrites two global Minetest settings: time_speed and node_highlight.

This is a problem because once you launch the game, the global Minetest settings affect other games, so the player must manually reset them back after playing this game. Especially losing the node highlight is very annoying. There is a solution:

It is not neccessary for you to overwrite those settings. So please just remove the offending settings set calls.

You can remove the time_speed overwrite. Instead, just reset the timeofday to the desired value every 10 seconds. Since the player never sees the sun or moon anyway, the player won’t notice this.

You can also now safely remove node_highlight overwrite since Minetest 5.9.0. Nodes can FINALLY block pointing. You can set pointable = "blocking" to the "glass" nodes. This prevents the player from pointing through the node while also hiding the selectionbox. The good thing about this is that this has a fallback for older Minetest versions.

Der1248 commented 3 weeks ago

I will fix that soon. I assumed the settings would only change locally for the respective game. Why is there even an option for games to change global settings? It would be much better if they only had a local effect, to prevent potential issues and confusion for players.

Der1248 commented 2 weeks ago

This is partially fixed with Labyrinthus 2.16.0. The time of day now resets every few seconds. I’ll revise the overwriting of node_highlight in the next updates.