search

DerAndere1 / Marlin

Optimized firmware for RepRap 3D printers based on the Arduino platform. The branch Marlin2ForPipetBot is optimized firmware for cartesian robots (lab robots, also known as liquid handling robots or pipetting robots)
https://derandere.gitlab.io/pipetbot-a8
GNU General Public License v3.0
53 stars 20 forks source link

Fixes for 6 axis #31

Closed bilsef closed 4 years ago

bilsef commented 4 years ago

Fixed some typos and made some improvements

bilsef commented 4 years ago

Here is the configuration I used to test this (on a Teensy 3.6 board).

6axisConfig.zip

bilsef commented 4 years ago

Changes to types.h fix issue #7

DerAndere1 commented 4 years ago

Thanks, I suspected types.h as the cause for this longstanding bug, but as you might know, code review can be more challenging than writing new code at times. So your fix is a massive help. Thanks a lot for digging into this!

DerAndere1 commented 4 years ago

I in my PR, I reverted your changes in Configuration.h because they were exposing the user to the non-standard macro LIST_N(N, V, ...) which might cause confusion and is probably not accepted by the maintainer of upstream MarlinFirmware (although I will use your style in my personal config file). Also, it is better to assume that the IJK axes are setup like the Z axis (with a lead screw) so default max feedrates and -accelerations should be similar to those for the Z axis. Using the same default values as for XYZ may cause hardware damage if users with lead screws forget to adjust the values.

bilsef commented 4 years ago

@DerAndere1, Sounds good. I will continue to work on other issues.