search

DerDakon / vpopmail

Patches for vpopmail as currently needed for Gentoo
3 stars 1 forks source link

i18n/encoding issues #2

Open thinrope opened 2 months ago

thinrope commented 2 months ago

I was looking at the code, saw https://github.com/brunonymous/vpopmail/issues/12 and spotted a few i18n/encoding issues...

In Gentoo branch:

$ for F in $(find . -type f |grep -v -P '\.(tar|png|git)'); do cat $F |iconv -f utf-8 >/dev/null || echo $F; done

iconv: illegal input sequence at position 75932
./ChangeLog
iconv: illegal input sequence at position 125
./contrib/addusers.pl

Getting all text back to proper UTF-8 (checking on the Net for the proper names), I got to the attached diff.

i18n_fix.txt

Please apply that (not sure on which branch you want it, so not giving you a PR), a few of the branches seem to be affected. And hopefully soon we'll have new net-mail/vpopmail-5.6.2.ebuild to test ;-)

DerDakon commented 2 months ago

Thanks for spotting this. All these things are before any of the git patches, i.e. fixing this is an actual commit. Please add a PR against the branch brunonymous-main which hopefully will become the actual upstream master eventually.

thinrope commented 1 month ago

I hope I did everything right in PR #3, ping me if you need anything else.