DerGoogler / MMRL

MMRL is an Android app that helps manage your own modules repository.
https://mmrl.dergoogler.com
GNU General Public License v3.0
424 stars 14 forks source link

[BUG] Info not available in url install #189

Closed james28909 closed 3 months ago

james28909 commented 3 months ago

Describe the bug When I select install in mmrl, it says info not available in url install. Unable to determine install cli.

To Reproduce Steps to reproduce the behavior: I just installed the cli tool and mmrl from GitHub and it can't install modules

Expected behavior I expect it to install modules

Screenshots Screenshot_20240619-123311_MMRL

Device info(please complete the following information):

Additional context I also tried changing modfs paths but still doesn't work.

DerGoogler commented 3 months ago

That the info is not available with a url install is supposed.

But why mmrl is unable to determine the install cli?

which root are you using?

james28909 commented 3 months ago

magisk in sbin/magisk

james28909 commented 3 months ago

just fyi, i am not sure which modfs path should be where and any help would be appreciated. it seems i had it working a while ago (maybe 6 months) on a different device, but that may have also been mrepo, i cant remember.

james28909 commented 3 months ago

After the update, I'm still having the same problem. Sure would like to fix it. Not much info on mmrl on Google do I really got no where else to turn. You know some things I can do to motivate this issue?

james28909 commented 3 months ago

su -c mmrl works:

su -c mmrl
MMRL comes now as command line interface, with multi module install support!

Usage: mmrl <COMMAND>

Commands:
  upself    Update MMRL CLI
  repo      Add new repositories
  info      View module infomation
  search    Search through modules
  download  Download any module
  install   Install any module
  enable
  disable
  remove
  help      Print this message or the help of the given subcommand(s)

Options:
  -h, --help     Print help
  -V, --version  Print version
DerGoogler commented 3 months ago

@james28909 where is the magisk bin stored?

james28909 commented 3 months ago

@james28909 where is the magisk bin stored?

magisk in /sbin/magisk

DerGoogler commented 3 months ago
ln -s /sbin/magisk /system/bin/magisk
james28909 commented 3 months ago

so i need to create a symbolic link just to use the app? doesnt that seem redundant? the app should be able to find all of this on its own when launched the first time. i shouldnt need to create any links to anything just to install a module, which magisk does fine already.

DerGoogler commented 3 months ago

magisk does not exist in /system/bin. but mmrl cli use it fron there

james28909 commented 3 months ago

is there some way to make mmrl cli search more paths than just /system/bin for magisk?

james28909 commented 3 months ago
Magisk, an open-source software tool, can use
the /sbin folder on Android devices to store
temporary data and inject binaries into PATH.
Magisk mounts a tmpfs directory to store
temporary data, and if the device has an /sbin
folder, Magisk will use it because it can also act 
as an overlay. This means that binaries like
magisk, magiskinit, and symlinks to applets will 
be directly stored in PATH. However, if the
device is running Android 11 or later, the /sbin
folder may not exist, so Magisk will use
/debug_ramdisk as the base folder instead. The 
 command magisk --path can be used to
determine the current base folder.

I'm on Samsung android 10 oneui 2.5 iirc. What would be the best way to get mmrl cli to work correctly?

Edit: so I guess I just need to figure out how to direct mmrl cli to use magisk in sbin?

When I run mmrl I get not found error:

/system/bin/sh: mmrl: inaccessible or not found

sudo mmrl
env: exec mmrl: No such file or directory
Non root PATH: /data/data/com.termux/files/usr/bin:/data/data/com.termux/files/home/.local/bin:/data/data/com.termux/files/usr/bin
root PATH:
:/data/data/com.termux/files/home # echo $PATH
/debug_ramdisk:/sbin:/sbin/su:/su/bin:/su/xbin:/system/bin:/system/xbin
DerGoogler commented 3 months ago

Should be fixed now. Please update to the latest MMRL-CLI release https://github.com/DerGoogler/MMRL-CLI/releases/tag/v0.3.8