search

DerKarlos / OSMeta

OSM "Metaverse"
Other
15 stars 2 forks source link

clone big-space and drop space/FloatingOriginSettings to constants #70

Open Raumpatrouille opened 5 months ago

Raumpatrouille commented 5 months ago

The crate bigspace uses FloatingOriginSettings (BigSpaceSettings) to let the user set the size and hysteresis of the galactic grid. We use the default values. So the values could be constants and the whole handling of the (big)space could be dropped.

This way a space.translation_to_grid cold not be called. We add a GalacticTranslate (::new)

There are many more fn in FloatingOriginSettings. Could we move them to GridCell?

oli-obk commented 5 months ago

we still would need space.translation_to_grid, we would just not need the space argument anymore. If we want to go down this route, we should rewrite the big_space crate to instead include this information in the GridCell type as an associated constant.

DerKarlos commented 5 months ago

big_space is now a local module to make all the extreme changes. The Constants are declared and used Space is removed from the application and replaced by a pub struct Space with Space::functions. (temporary)

Next: Creating classes for all types of positions. Hug the functions into the classes.