search

DerKoun / bsnes-hd

bsnes fork that adds HD video features
GNU General Public License v3.0
624 stars 35 forks source link

Fix build with gcc-13 #124

Closed heitbaum closed 1 year ago

heitbaum commented 1 year ago

Error was: In file included from ../nall/arithmetic.hpp:69: ../nall/arithmetic/natural.hpp: In function 'void nall::div(const uint4096_t&, const uint4096_t&, uint4096_t&, uint4096_t&)': ../nall/arithmetic/natural.hpp:239:23: error: 'runtime_error' is not a member of 'std' 239 | if(!rhs) throw std::runtime_error("division by zero"); | ^~~~~ ../nall/arithmetic/natural.hpp:239:23: note: 'std::runtime_error' is defined in header ''; did you forget to '#include '?

DerKoun commented 1 year ago

Thanks. This doesn't break any other version, right? (I know very little on the topic.)

edit: The Linux ARM build being broken is probably unrelated. It never worked properly.

heitbaum commented 1 year ago

Thanks. This doesn't break any other version, right? (I know very little on the topic.)

This header is a C++11 header

C++11 was supported in gcc-4.8, so you will be fine.

DerKoun commented 1 year ago

Merged. Thanks for contributing. As someone with little to no C++ experience, things like this would take me hours or days for one line. So I'm really glad you took the issue on and took the time for a PR. (And also thanks for another motivation to get back into the project.)

heitbaum commented 1 year ago

Merged. Thanks for contributing. As someone with little to no C++ experience, things like this would take me hours or days for one line. So I'm really glad you took the issue on and took the time for a PR. (And also thanks for another motivation to get back into the project.)

Your welcome. Glad to help with your mojo 😎