search

DerKoun / bsnes-hd

bsnes fork that adds HD video features
GNU General Public License v3.0
632 stars 36 forks source link

Resolutions are incorrect; were correct in beta-9 #29

Closed Knucklesfan closed 4 years ago

Knucklesfan commented 4 years ago

Hi. Today I recently upgraded to beta-10, and I really enjoy the new features. Sadly, it has one massive bug which seriously affects most monitors/games. In previous builds of bsnes-hd, when set to 16:9, the resolution was set to 400x224. however, now, bsnes-hd runs at 384x224, which cuts off a serious amount of screen resolution. Also, without enabling overscan, the picture cuts off the first few pixels from the top of the image, which can hurt some games. Enabling overscan causes the black bars as seen here, and is quite annoying. None of these issues were present in the classic bsnes-hd. The following screenshots were taken using print-screen on 2 1080p monitors, running in the 16:9 aspect ratio. weirdresolutions1 On the right is bsnes-hd beta 10 while on the left is bsnes-hd beta 9, the difference is pretty obvious. I haven't tested on the libretro core yet, but I'd assume the same bugs are present. None of these bugs are seen in regular bsnes, which leads me to believe its a problem either A: on my end, or B: on the emulator's end. Either way, hope this helps. I hope this helped you fix your wonderful emulator.

DerKoun commented 4 years ago

Some of those things are intentional, but work-in-progress. There may also a bug or 2 in there, but spontaneously I don't see any. I'll update this issue when I look into it.

For the black bars: Disable both Show Overscan and Aspect Correction. Then (at 16:9) you get exactly a 5th of 1080p, so it will scale perfectly.

Knucklesfan commented 4 years ago

Some of those things are intentional, but work-in-progress. There may also a bug or 2 in there, but spontaneously I don't see any. I'll update this issue when I look into it.

For the black bars: Disable both Show Overscan and Aspect Correction. Then (at 16:9) you get exactly a 5th of 1080p, so it will scale perfectly.

If I disable overscan, the top few line of pixels are cut off, is that intentional?

DerKoun commented 4 years ago

Yes, see: https://github.com/DerKoun/bsnes-hd/blob/master/README.md#user-content-differences-in-settingoptions-from-bsnes Correct widescreen aspect ratios for every combination of overscan and aspect correct settings is planned. That is a work-in-progress ATM.

DerKoun commented 4 years ago

Widescreen AR is now applied based on the related settings. Also you can specify the additional pixel columns directly using setting override files.