search

DerKoun / bsnes-hd

bsnes fork that adds HD video features
GNU General Public License v3.0
632 stars 36 forks source link

Line byproduct #39

Closed JimPancakes closed 3 years ago

JimPancakes commented 4 years ago

Sorry if this is the wrong place for this. I was just wondering if there is any way to get rid of the line that shows up on the right side of the screen:

Terranigma (Europe)-200325-220527

I've seen this phenomenon with games that go beyond their original resolution.

When the Aspect ratio is set to none the line no longer shows up at the price of widescreen of course. Could it be possible to implement some sort of adaptive aspect ratio that goes to 16:9 only when Mode 7 is detected or something like that?

DerKoun commented 4 years ago

Please see https://github.com/DerKoun/bsnes-hd#widescreen-widescreen-mode

Widescreen (WideScreen Mode)

Enables experimental widescreen functionality

  • none: do not enable widescreen
  • Mode 7(default): enable widescreen for Mode 7 scenes (works for most games)
  • all: enable widescreen for all scenes (non-Mode 7 scenes only work acceptable in some games, but many have mostly artifacts)

Does this already cover your request?

JimPancakes commented 4 years ago

Please see https://github.com/DerKoun/bsnes-hd#widescreen-widescreen-mode Does this already cover your request?

I'm having that line with Mode 7 selected in the widescreen menu. I've toyed with it a bit and I saw what it does. The line only disappears when the aspect ratio is set to none but then I have no widescreen.

By aspect ratio I mean the option in the emulator. Also I've seen this line present in the second screenshot of this page.

DerKoun commented 4 years ago

I'll look into it. But I'll have this at low priority at the moment.

JimPancakes commented 4 years ago

That's fair. Thanks!

JimPancakes commented 3 years ago

Me again. If possible, please fix this in the next release.

DerKoun commented 3 years ago

The roadmap for the next release is pretty set. But if you want to help getting this issue solved sooner you can provide more information:

If I can easily reproduce the issue I may be able to resolve it in the following release.

JimPancakes commented 3 years ago

bsnes-hd beta 10.4 used Windows 10 Home 64-bit - Version: 20H2 - OS build: 19042.985 No special hardware. GPU - Nvidia GTX 1660 Ti - Driver version: 465.89 CPU - AMD Ryzen 5 3600 RAM - 16 GB DDR4

Settings are default:

settings_01 settings_02 settings_03

Screenshots were taken in windowed mode with these settings (the problem does show up in fullscreen as well, don't worry):

settings_04 settings_05 settings_06

In any of the games tested the problem never shows up during Mode 7 sequences (when the game actually goes widescreen).

Kirby's Dream Land 3 (USA)

The line first shows up in the intro animation for GRASS LAND (nothing before that):

Kirby's Dream Land 3 (USA)-001

It then shows up in gameplay but it doesn't go all the way down, not covering the stats segment of the screen (harder to see but it's there):

Kirby's Dream Land 3 (USA)-002

Interestingly the transition animation does cover it:

Kirby's Dream Land 3 (USA)-003

Super Mario RPG - Legend of the Seven Stars (USA)

It first shows up in the intro:

Super Mario RPG - Legend of the Seven Stars (USA)-001

And the slowly disappears as the screen darkens:

Super Mario RPG - Legend of the Seven Stars (USA)-002

Does not show up in the title screen or the save select. Shows up again here:

Super Mario RPG - Legend of the Seven Stars (USA)-003

It does not show up while moving about but it is present in combat:

Super Mario RPG - Legend of the Seven Stars (USA)-004

It also shows up in: Terranigma, Super Mario World, Super Mario World 2 - Yoshi's Island, Seiken Densetsu 3 (only in the character select and save screen as far as I saw, not in gameplay), Kirby's Dream Course.

The only one I found where it didn't show up is Contra III - The Alien Wars but I only played a bit of the first level.

Again, it never shows up in Mode 7 sections from what I saw at least. And certain elements, like text boxes or transition animations, do cover it.

It feels like a garbage pixel line. If I take any of the screenshots, resize them to the SNES's actual resolution of 256×224, then the line falls outside of this. If I set Widescreen to none in settings then the line is no more:

Kirby's Dream Land 3 (USA)-004

Just a dumb suggestion from an unknowledgeable person, maybe you can make an option where the emulator switches Widescreen to Mode 7 when it detects it running and make it go to none when it's not?

If you want more screenshots and games tested please ask! Sorry if those weren't enough.

Thank you for taking an interest in this!

DerKoun commented 3 years ago

Thank you for the detailed information. I think I found the cause (can't test right know). The background color seems to be painted one pixel to far to the right. If I can verify it this will be in fixed in the next release.

DerKoun commented 3 years ago

Fixed in latest release (10.5). Again thanks for your efforts.

For those interested: The change is just replacing one <= with <

JimPancakes commented 3 years ago

Thanks a lot man! Appreciate the mention in the changelog. All the best.

DerKoun commented 3 years ago

Appreciate the mention in the changelog.

You definitively spent more time on this issue than I did.