search

DerKoun / bsnes-hd

bsnes fork that adds HD video features
GNU General Public License v3.0
625 stars 35 forks source link

Background moved 4px to the right in 16:10 and 21:9 #60

Closed wojpawlik closed 3 years ago

wojpawlik commented 3 years ago

Correct:

16:9

Super Mario World (USA)-16_9

2:1

Super Mario World (USA)-2_1

Incorrect:

21:9

Super Mario World (USA)-21_9

16:10

Super Mario World (USA)-16_10

DerKoun commented 3 years ago

The offset seems to be the remainder of dividing the widescreen area width by 8. Didn't find the cause at a quick glance at the code, but I'll look into it in detail. Can I assume that the scale factor make no difference?

wojpawlik commented 3 years ago

Yes, scale factor (Settings > Size) makes no difference.

DerKoun commented 3 years ago

Fixed in new beta 10.4 The widescreen area size is now always rounded to a multiple of 8. @wojpawlik Can you please confirm the issue is solved completely?

wojpawlik commented 3 years ago

Confirming fix: obraz obraz

wojpawlik commented 3 years ago

Curious (not complaining), why did the scanline shader turn on after 10.3 -> 10.4 upgrade, even tho it's not listed?

obraz

DerKoun commented 3 years ago

That's actually the widescreen marker being rendered incorrectly for scales of 2 or higher. I have pushed another hotfix for that. Thanks for reporting.