search

DerKoun / bsnes-hd

bsnes fork that adds HD video features
GNU General Public License v3.0
632 stars 36 forks source link

Memory leak? #70

Closed MapleStoryPSN closed 3 years ago

MapleStoryPSN commented 3 years ago

Tested on both the current bsnes-hd beta retroarch core and standalone emulator. Launch any game and monitor ram usage. It will gradually climb at a rate of roughly 1mb a second, even if left completely idle in game on a static screen. No other SNES cores, base bsnes included, exhibit this behavior.

DerKoun commented 3 years ago

Great find, thank you. That is what happens when a Java developer wades through the circle of hell that is C++. He doesn't deallocate his arrays. There were two happening every frame(!!) and one when you change Color Adjustments. And all together were literarily fixed with 3 lines of code.

DerKoun commented 3 years ago

This fix is now live for the libretro core. That also fixes breaking flickering on the Switch.

DerKoun commented 3 years ago

Fixed in the new beta 10.4 @MapleStoryPSN If you have time to verify I'd appreciate it.