DerKoun / bsnes-hd

bsnes fork that adds HD video features
GNU General Public License v3.0
624 stars 35 forks source link

Settings for Widescreen mode using Retroarch Plus on Android #86

Closed rdsngit closed 2 years ago

rdsngit commented 3 years ago

@DerKoun In the Patreon comments discussion for the Super Mario World Widescreen beta v01 you explained that sometimes Android users of the bsnes-hd core in Retroarch Plus found .bso files were not overriding the local core settings. Would it be useful to add a section to the bsnes-hd Readme to explain to Android users which settings need to be used for Widescreen?

For context, I had the patched .sfc file in the same directory as the SMW .bso file. It initially displayed in regular SNES aspect ratio, eg 4:3. Then I changed some of the Settings that I though were related to get 16:9 Widescreen mode running successfully.

I've included a set of screenshots showing all the Settings, here are the ones I think could have been key to getting Widescreen working

Widescreen Mode = all
Widescreen Aspect Ratio = 16:9
Widescreen Sprites = unsafe
Pixel Aspect Correction = Off
Before After
widescreen-not-working-smw-bsnes-hd-android-retroarch-plus widescreen-smw-bsnes-hd-android-retroarch-plus
Settings part 1 Settings Part 2 Settings Part 3
part1of3-widescreen-settings-bsnes-hd-android-retroarch-plus part2of3-widescreen-settings-bsnes-hd-android-retroarch-plus part3of3-widescreen-settings-bsnes-hd-android-retroarch-plus
DerKoun commented 3 years ago

I hope I can fix the BSO issue. But I'll talk to Vitor about including the settings (they vary between different games/patches). For that I'll have to add at least one BSO-exclusive setting to the core option, which I have planned for the next release as well.

rdsngit commented 3 years ago

Sounds like you have some ideas for fixing this for future releases. Could it be useful to have a bsnes-hd core setting to tell the core to look for and use the BSO file if it is present? Eg something like "Use BSO file for Settings = true / false"

DerKoun commented 3 years ago

Not sure in which use-case disabling the BSO would be useful. But it is possible.

rdsngit commented 3 years ago

Ok, if you're planning to fix that so it detects and applies BSO automatically then that sounds a good approach. Should we close this issue if you're already working on this for a future release?

DerKoun commented 3 years ago

I'll close it after the release.

DerKoun commented 3 years ago

Please try the BSO again in the latest version (10.6) and let me know if it works. If it doesn't first please tripple check if you named the 3 files correctly. Then, if possible, try the RetroArch APK instead of the Play Store version. Thanks

rdsngit commented 3 years ago

@DerKoun Thanks for the update - I can confirm this is now working.

Tested this today using the bsnes-hd version 10.6 using the latest version of Retroarch Plus for Android.

Steps:

This worked in 16:9 widescreen mode. There were some related things about aspect rations that I found. If you go into the core settings and change Widescreen Aspect Ratio to 21:9 it stretches the 16:9 game display area and 16:10 squashes the game display area. I assume these are left in for users that have different size displays and want to user the SMW Widescreen patch.

rdsngit commented 2 years ago

Closing this issue now that the fix has been released.