DerKoun / bsnes-hd

bsnes fork that adds HD video features
GNU General Public License v3.0
624 stars 35 forks source link

[Libretro] Upgrade Core Options to v1.3 with sublabels and translation support #87

Closed Ryunam closed 2 years ago

Ryunam commented 3 years ago

This PR updates the core options in the libretro implementation of bsnes-hd to version 1.3, allowing for descriptions of each option in the sublabels as well as translation support. See here for further reference: https://github.com/libretro/libretro-common/tree/master/samples/core_options

It is essentially a backport of what I had implemented for the up-to-date bsnes-libretro repo, as seen in https://github.com/libretro/bsnes-libretro/pull/4, coupled with a few changes and descriptions that were created from scratch for the widescreen-related settings and the other options that are specific to the bsnes-hd project.

Here is a recap of the main changes:

This was tested on Windows 10 x64 and everything seems to be working well. Here's a sample picture of how the core options look now:

bsneshd-coreoptions

DerKoun commented 3 years ago

Very nice, thank you. I really appreciate the attention to detail, like for "overscan" (which I should have made a "crop" option form the beginning). I think this will be merged with only minor tweaks.

Ryunam commented 2 years ago

Hi @DerKoun, do you have an estimate of when this could be likely implemented in the core? No pressure intended of course, just wondering if this requires any change or fix on my end. Thanks in advance!

DerKoun commented 2 years ago

Sorry @Ryunam, I already had merged your code locally and tweaked it. Then I got into another phase where I wasn't motivated to work on this (or any) project at all, this time brought on mostly by grieve for Near. I'm working on pulling myself out of that low and get more active on the project again. You're work will definitively be in the next version, with some tweaks from me. I want to apologize for the delay and lack of communication after you put in all the work for this great improvement.

Ryunam commented 2 years ago

No problem at all, I can completely understand and empathize with how Near’s loss has impacted anyone’s motivation for working on a project like this.

Definitely take your time. I will be looking forward to the next release and, whether you require any input on my end with regards to this implementation or just want to chat, let me know!