search

DerKoun / bsnes-hd

bsnes fork that adds HD video features
GNU General Public License v3.0
632 stars 36 forks source link

Bugs with perspective correction enabled and supersampling #9

Open Max833 opened 5 years ago

Max833 commented 5 years ago

https://github.com/byuu/bsnes/issues/56

https://github.com/byuu/bsnes/issues/57

Supersampling with"Blazing Skies (Europe)".

supersampling

DerKoun commented 5 years ago

Thanks for reporting. Please let me know the following for all 3 issues: Do these occur in the latest bsnes-hd? With which of the "Perspective correction" modes does each one work and with which ones not? Do different scale and supersampling factors make a difference? Please sumerize the issue in text form, so we can be sure we mean the same.

Max833 commented 5 years ago

Do these occur in the latest bsnes-hd?

Beta 9 with default settings: "ABC Monday Night Football" works and "7th Saga" doesn't. Not exactly like bsnes, but it's still there.

With which of the "Perspective correction" modes does each one work and with which ones not?

Both games don't work with "on/wide", "on/medium" and "on/narrow".

Do different scale and supersampling factors make a difference?

Sorry, this wasn't completely correct. Factors doesn't matter. When I enable scale >240p, disable "Perspective correction" and enable "Supersampling" this green scanline appears.

Thanks for reporting.

You're welcome.

DerKoun commented 5 years ago

Looks like one requires improved perspective detection (or, even better, improved segmentation of Mode 7 line groups) and one has the weird lines that sometimes show up without perspective correction. I will add those to my test cases. Any additional game may help finding the root cause of an issue. Can't promise any time frame for the improvements ATM, though. Thanks again

Max833 commented 5 years ago

@DerKoun: Thanks! "Captain Tsubasa J - The Way to World Youth (Japan)" is a really interesting game as well. A lot of weird things going on there with "Perspective correction" and "Supersamling".

DerKoun commented 5 years ago

Thanks for your continued efforts. Having all games with HD Mode 7 related problems (or just complex cases) in this issues is great. I'll sort them into subcategories after the first analysis of each.