Deraen / sass4clj

SASS compiler for Clj, Lein and Boot, using Libsass Java wrapper
70 stars 16 forks source link

Support a more complex sass library #16

Closed flyingmachine closed 8 years ago

flyingmachine commented 8 years ago

This change was motivated by my need to support a Bower installation of the Susy sass library.

Changes:

(find-resource (io/resource (add-underscore url)))      
(find-resource (io/resource url))

It looks like these were used to support the use case in the test file where we were creating a file in a temporary directory, and trying to import resource files from the created file. I couldn't see why one might want this functionality.

Still, that's not enough reason to remove the functionality. The larger reason is that those lines were causing the susy import to throw the exception An import loop has been found.

Deraen commented 8 years ago

Thanks!

I'l try to remember why those lines existed and if removing those has some other consequences.

Other thing, I don't want 4000 lines of external code added to the repo. Either:

Deraen commented 8 years ago

I updated Jsass in another commit: https://github.com/Deraen/sass4clj/commit/41ac016018174c3c2848bc694da44f8ee4bfe0b4