search

DerbyBoutTime / bouttime

'Bout time we got this game started.
Other
32 stars 11 forks source link

Remove references to global installation #142

Closed miketheman closed 8 years ago

miketheman commented 8 years ago

Code review: @WFTDA/bouttime, @WFTDA/code-monkeys

The NPM-packaged artifact is not currently a viable method for installation yet, and have tripped up users despite the warning.

Remove these references until a time the package is stable enough to reintroduce this install method.

Refs #138 [ci skip]

Signed-off-by: Mike Fiedler miketheman@gmail.com

anotherlizwong commented 8 years ago

I noticed that, but reading through the readme with the lines removed implied "there is intention to have NPM support but please use our developer instructions right now" and obfuscating the npm install instructions stops people from blindly running them.

miketheman commented 8 years ago

@kweerious Can you elaborate on that a bit? I'm not sure I understand the server command expecting global context - a human can do all sorts of things, and we're trying to prompt them in the (current) safe direction. Is there other bits I should look to remove, like what @anotherlizwong referred to?

kweerious commented 8 years ago

@miketheman npm install -g will install globally, in this instance it will allow bouttime-server to work versus bin/bouttime-server or binaries installed in node_modules/.bin/. I'd like to pull the line referencing that.

Sorry that got lost answering on mobile.

miketheman commented 8 years ago

@kweerious Thanks for pointing those out. Removed in most recent version.