DerbyBoutTime / bouttime

'Bout time we got this game started.
Other
32 stars 11 forks source link

Bower components live inside app/ directory #144

Closed miketheman closed 1 year ago

miketheman commented 8 years ago

https://github.com/WFTDA/bouttime/blob/master/.bowerrc customizes the location of the bower_components directory to live inside the application code subdirectory.

package.json and gulpfile.js are the other two files that make mention of these paths, using browserify-shim

In #129 the committed bower_components were removed from the repo, as they are installed artifacts, and should not be committed here.

Since the installed location lives inside app/ this directory has the ability to "bleed through" a Docker container volume layer and arrive on the host machine, with low guarantees of being refreshed/updated since during the docker build, the contents of the app/ directory are sent to the container. This can slow down build times as well.

Should we move the ./app/bower_components/ to ./bower_components/, similar to ./node_modules/, especially considering that the gulpfile.js already sets a destination for dist/bower_components/ ?