search

Derecho-Project / derecho

The main code repository for the Derecho project.
BSD 3-Clause "New" or "Revised" License
182 stars 46 forks source link

Fix bugs in our CMake dependency declarations #259

Closed etremel closed 10 months ago

etremel commented 10 months ago

Attempting to compile Derecho on a Fractus node where the LibFabrics and nlohmann-JSON libraries were not installed system-wide revealed two bugs in our CMake declarations:

  1. The Conf module did not declare its dependency on nlohmann_json even though conf.cpp includes nlohmann/json.hpp
  2. The top-level CMakeLists did not call include_directories() after calling find_package(libfabric), which is necessary for packages that do not export CMake targets (the "old way") - we need to both link ${libfabric_LIBRARIES} and include ${libfabric_INCLUDE_DIRS}.