Derecho-Project / derecho

The main code repository for the Derecho project.
BSD 3-Clause "New" or "Revised" License
186 stars 47 forks source link

Exposing more information through GroupProjection. Removing PAGE_SIZE macro definition. #265

Closed songweijia closed 8 months ago

songweijia commented 10 months ago

Exposing more group configuration information through GroupProjection. Before, the information was retrieved through derecho::Conf API, which loads the information from the configuration file. That's not optimal regarding the source of information. Instead, the active group class should take responsibility.

The other minor change in the pull request is the removal of PAGE_SIZE definition. Previously, I defined it to getpagesize() call. That uses the runtime information. Although it does not cause any issues in most cases, it prevents static/compile-time checking. Instead, PAGE_SIZE should derive from the compile-time detector as a constant. However, Derecho only uses it in the file system log layer, so I removed it here.