search

Derecho-Project / derecho

The main code repository for the Derecho project.
BSD 3-Clause "New" or "Revised" License
182 stars 46 forks source link

Re-issuing v2.4.0 #277

Closed songweijia closed 2 months ago

songweijia commented 2 months ago

After a discussion with Edward, we decided to re-issue v2.4.0 with the following changes: 1) Fix the include directives (from "" to <>), and 2) Introduce the config.h.in so that HMEM feature is controlled and v2.4.0 works for 'tcp' and 'socket' libfabric providers.

TODO: include Edward's changes making USE_VERBS_API compilable (not tested and not recommended as we've developed around libfabric for years.)

songweijia commented 2 months ago

@etremel I've reg-tested this version with the latest cascade master branch. It works as I expected. You can go ahead with another pass of the change. I think it's ready to merge to the master for reissuing v2.4.0.

etremel commented 2 months ago

Thanks, this looks good. I'll have to merge this pull request first and then re-apply my changes to make USE_VERBS_API compile, since I can't add commits to your repository, but that shouldn't be too hard.