Open DerekStride opened 11 months ago
It would also be great to have parser.c
in the tagged commits for releases, not just the assets. Emacs has a built-in workflow to install tree-sitter grammars, which clones the repo at a specific tag and looks for parser.c
file there. Because the releases are tagged on the main
branch and not gh-pages
file is not present there, so the workflow doesn't work for tagged releases in this repo
@qoops-1 have a look at #120 We have discussed this issue already with the emacs guys. The problem is, that the parser.c
is auto generated and gets quite large.
@matthias-Q thank you for the link, my takeaway from it is that current approach is to track hashes on gh-pages
for corresponding tags of releases on main
. It would be easier if gh-pages
was also tagged, so that instead of hash I could specify that tag.
That might be possible with a custom release workflow
On a related note, could you include the grammar.js
in the gh-pages
branch? Omitting this breaks nvim-treesitter's TSInstallFromGrammar
.
EDIT Never mind, I see you include the grammar.json
; that is good enough for us.
What
Currently the only assets included on the release are the source files (see https://github.com/DerekStride/tree-sitter-sql/releases/tag/v0.2.0). We should generate & add the parser files to the release as well. We could even precompile the parser for difference architectures and make that available too.