search

Derekljh / pe

0 stars 0 forks source link

Updating name changes the index of the contact #2

Open Derekljh opened 6 months ago

Derekljh commented 6 months ago

Not sure if this is intended, but updating the name of a contact can change the index of the contact based on alphabetical order, which was not stated in the User Guide. This can be a little inconvenient to users trying to edit the contact multiple times, and did not realize that the index of the contact has changed. This is especially so when there are many contacts in the list (>20), and it becomes inconvenient to scroll down to find where the contact has moved to. In my opinion, I don't think I want the index of the contact to change when I edit the name.

Steps to reproduce:

  1. Used testing data contact no.2, Bernice Yu.
  2. Rename Bernice Yu to Yu Bernice with command uc 2 n/Yu Bernice
  3. Note that the index of the contact changed from 2 to 7.
soc-pe-bot commented 6 months ago

Team's Response

The index is simply the position of a contact in the list. It is not meant to be associated with any person, nor did we mention such information in the UG. Furthermore, filtering the list also changes the index of persons. The reason why the index changes is because the list is meant to be in sorted order, so the index of the person changes to maintain sortedness.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I think this response is missing my point of the issue, being that it is inconvenient for the user to track where the contact has changed to after editing the contact when there is a long list of contacts (>20). This could be a notinscope issue, but in my opinion, I think it is fair to consider the index not changing so as to not inconvenience the user.