search

Derfuu / Derfuu_ComfyUI_ModdedNodes

302 stars 31 forks source link

dynamic prompt #24

Open za-wa-n-go opened 2 months ago

za-wa-n-go commented 2 months ago

I often use the TextBox by converting the prompt part with ClipTexEncode, but with the recent update, the comment out function derived from the dynamic prompt such as // used in the dynamic prompt does not work when converting, which has been troubling. I thought it was a bug, but it seems to have been a specification change. Is it possible to make the dynamic prompt work on the conversion side?

Derfuu commented 2 months ago

Might be fixed now with additional node (DynamicPrompts Text Box) with dynamicPrompts enabled, Also if use it as pass-through it wouldn't work. Could say same about standard nodes with this property.

To illustrate how it works and how it didn't:

image

za-wa-n-go commented 2 months ago

Sorry! The Text Box node has become unreadable, and I am having trouble applying past prompts. Is this update related? Is there any way to make the contents of past nodes readable?

Derfuu commented 2 months ago

Can't say anything about update related stuff, but i think i could fix it somehow.

Derfuu commented 2 months ago

found a way how to do it. Need this dynamic prompts extension.

za-wa-n-go commented 2 months ago

When you install this extension, the red node will be revived...?

Derfuu commented 2 months ago

If there are red nodes from my extension, then - try to update mappings. already answered about it here and here

wes-kay commented 1 month ago

If there are red nodes from my extension, then - try to update mappings. already answered about it here and here

This didn't fix my issue, and you also shouldn't be updating plugins like this. Give users the choice in updating don't put breaking updates to production without testing. Multiple people including myself have asked why you aren't just reverting your changes and doing it properly. https://github.com/Derfuu/Derfuu_ComfyUI_ModdedNodes/issues/23#issuecomment-2093888448