search

Derfuu / Derfuu_ComfyUI_ModdedNodes

365 stars 40 forks source link

Issue with interacting with seeds on integer input slots #8

Closed TheMcSebi closed 1 year ago

TheMcSebi commented 1 year ago

Hi, while using your (very useful!) custom nodes I noticed that I had issues using the same primitive's output that feeds my seed inputs as custom node input. The issue comes from the INT type using sys.maxsize as maximum value, while seeds may grow as large as 0xffffffffffffffff. I didn't open a PR because I'm not entirely sure if this was on purpose or could break other things I'm currently unable to test. This is the line of code I'm talking about: https://github.com/Derfuu/Derfuu_ComfyUI_ModdedNodes/blob/2ace4c463d5b2063de35e46ebb9bd3f10e2d34b4/components/fields.py#L10 Thanks for sharing those nodes with the public.

TheMcSebi commented 1 year ago

I created a PR on the ComfyUI library instead: https://github.com/comfyanonymous/ComfyUI/pull/1198