Derivitec / vscode-dotnet-adapter

MIT License
7 stars 8 forks source link

#15 Feature flag CodeLens integration, don't combine globs that use group conditions #16

Closed andrewbridge closed 4 years ago

andrewbridge commented 4 years ago

Fixes an issue where VSCode didn't allow nested group conditions in globs such as {**/*{nunit,xunit}.dll,**/node_modules/**}. This often occurred when we tried to combine globs together for efficiency.

We now use a optimisation strategy where we always loop round multiple search patterns, but will optionally condense the number of individual search patterns if group conditions aren't used. This optimisation can be improved in the future.

We also combine config watching logic into the ConfigManager and only use one instance of the config manager across the codebase. This allows easy watching across the codebase as well as disposal of watchers.