Derpius / VisTrace

Garry's Mod binary module for tracing meshes at high speed on the CPU (and much more)
https://derpius.github.io/VisTrace
MIT License
28 stars 1 forks source link

[bug] Regression in mipmapping calcs #96

Open Derpius opened 1 year ago

Derpius commented 1 year ago

Describe the bug Regression has occurred (likely when computing triangle area) after the MDLParser integration that affects mipmapping

To Reproduce Steps to reproduce the behaviour:

  1. Use an existing ray tracer
  2. Set the ray cone params when calling traverse to enable texture filtering

Screenshots image

yogwoggf commented 1 year ago

I'm not familiar with VisTrace's tracing internals anymore since the MDLParser update. However, I did trace the regression back to the commit which merges MDLParser into the master branch.

See 5c2d05a. I tried doing basic code swapping with the earlier versions, but given that the literal triangle data has changed completely, nothing worked... I also don't know how to fix this issue since I'm not very acquainted with MDLParser yet. Will keep trying, but MDLParser merge is most likely the cause of this.

Derpius commented 1 year ago

We’ll ignore the fact I said where the regression was introduced and probable cause in the issue description :trollface:

Derpius commented 2 months ago

Identified the issue:

If there's no limitation preventing passing this data on the constructor, we should do that instead (which fixes this issue)