search

DerpleMQ2 / rgmercs

Lua version of RGMercs Script
12 stars 22 forks source link

Fallback checks for group buffs (mainly for mercenaries) will still cast each group buff on each target. #237

Open AlgarDude opened 1 month ago

AlgarDude commented 1 month ago

In a party with 3 mercs, when buffs are needed, that means you remem and recast 4 times (multiplied by how many group buffs you have).

Making these only check the caster is not a proper fix IMO, as the point of group buff rotation is being able to buff the "group", as sometimes only one or two dudes will die/etc (and they need rebuffs).

The process of "check all the dudes for each missing buff and then cast each missing buff" needs to be changed somehow to casting a buff as soon as one check is found in need of it (which then stops it from being found in need on the next dude in line).

AlgarDude commented 1 month ago

I plan on toying with some adjustments to GroupBuffCheck to try to overcome this very soon that will leave TargetHasBuff() and SpellStacksOnTarget() unchanged.