DerpleMQ2 / rgmercs

Lua version of RGMercs Script
11 stars 21 forks source link

Group buffs being repeated (up to) six times. #81

Closed AlgarDude closed 1 week ago

AlgarDude commented 1 month ago

Group buffs commonly cast once for each member missing them at the time the script checks the group's buffs. This results in a spell being memmed, cast, and the old spell rememmed up to six times.

RobbanEQ commented 1 month ago

This is really annoying. Anyone knows why?

AlgarDude commented 1 month ago

I believe that I do know why but requires some rework beyond my ability, it's in my short list of things to bother Derple about XD

Basically I think (without digging into it) all the targets are checked in the entry and then the spell is applied to each that need it, and I need to look if there is a way I can sneak code in to stop the other entries if the spell is a group spell. Just need to get to it, working other issues

AlgarDude commented 1 month ago

I am testing a rework of group buffs that addresses this issue

AlgarDude commented 1 week ago

Recent changes and reworks to underlying functions seems to address this issue, and we have a few more changes in the pipe.