Derpseh / Spyglass

Nationstates Sheet-generator for easily finding approximate update times
GNU General Public License v3.0
11 stars 10 forks source link

3.0.2 bugfix changes behavior of time around multi-second regions #41

Open EWSouls opened 1 year ago

EWSouls commented 1 year ago

2.x Spyglass versions reported timestamps as "start of update in a region" i.e. image

3.0.2 (times fixed) reports them as "end of update in a region" i.e. image

the impact of this is...small, but the 2x design was intentional design - since you have to be inside a region when update starts there, it's more natural, for both other tools and for manual triggers, to display the time update starts in that region - or in terms of spyglass code, the cumunations-based time before adding that region's number of nations.

It really only matters for multi-second regions, and "multi-second regions relevant to R&D" are a minority, but this behavior does still deviate from the intentional design as implemented in prior versions.

Please restore the prior behavior of reporting the "start of update" for multi-second regions in 3.x.