search

Derpthemeus / ChampionMastery.GG

League of Legends champion mastery highscores
https://championmastery.gg
MIT License
77 stars 28 forks source link

Sort by required points to level up #13

Closed CodeNGame closed 7 years ago

CodeNGame commented 7 years ago

Can we add a column to the summoner page to show the required points to level up? I wrote a script for my use, but i think it would be helpful for others if they are also interested in max leveling all champs. Script: https://pastebin.com/uxY72LxF

Derpthemeus commented 7 years ago

Right now sorting by progress is a bit messed up. It currently sorts champions that are level 1-4 by progress to the next level (as a percentage), but sorts champions that are level 5-6 by progress to the max level. In the upcoming days, I'll try to get some feedback from users about their opinions on sorting by progress (including their opinions on if they want to be able to sort progress by the percentage to next level, the points to the next level, or both), and update the site based on that.

Once I gather some feedback on the issue, are you interested in creating a pull request to add the feature, or are you just suggesting that I add the feature?

CodeNGame commented 7 years ago

If you are inclined to add, I can take care of the changes for the feature.

Derpthemeus commented 7 years ago

I gathered some feedback, and quite a few people are interested in having a 2nd progress columns. 1 column will be the progress towards the max level, and the other column will be progress towards the next level (by points required to level up).

Are you still interested in adding this feature yourself?

CodeNGame commented 7 years ago

Cool. Yep, I ll add the feature sometime next week and follow up here.

However ddragon still seems to be down. Let me know if there is a quick workaround to make the server run without it.

CodeNGame commented 7 years ago

I have the (tested) changes on my local. What is the next step here?

PS: I am new to GitHub, I couldn't push to a new remote branch. Without that, I don't see any options to make a PR. Is forking the only way?

page load: https://imgur.com/w3vuzcr sorted asc: https://imgur.com/d1oUUbk sorted desc: https://imgur.com/OxBwqiA

Derpthemeus commented 7 years ago

You'll need to fork the repository to create a PR. The basic steps are:

  1. Fork the repo
  2. Push your changes to the forked repo
  3. Make a pull request from the forked repo to the original repo

You can find more detailed instructions here

CodeNGame commented 7 years ago

Thanks. Created the PR.

Derpthemeus commented 7 years ago

Thanks for your contribution!