search

DerrickBrayanClayton / protobuf-net

Automatically exported from code.google.com/p/protobuf-net
0 stars 0 forks source link

create UInt64Serializer for ulong, not Int64Serializer #111

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
This is a copy-paste typo in Meta/ValueMember.cs, 
ValueMember.GetCoreSerializer(Type type, out WireType defaultWireType) 
method, where an errorneous serializer is selected for UInt64:

                case TypeCode.UInt64:
                    defaultWireType = GetIntWireType(dataFormat, 64);
                    return new Int64Serializer();

needs to read

                case TypeCode.UInt64:
                    defaultWireType = GetIntWireType(dataFormat, 64);
                    return new UInt64Serializer();

Original issue reported on code.google.com by oleg.zak...@gmail.com on 4 Jun 2010 at 4:38

GoogleCodeExporter commented 8 years ago 
Thanks. I'm working through the kinks slowly - that is helpful, cheers.

Original comment by marc.gravell on 4 Jun 2010 at 6:54

GoogleCodeExporter commented 8 years ago

Original comment by marc.gravell on 4 Jun 2010 at 6:55

GoogleCodeExporter commented 8 years ago 
I've had chance to look at this, and it looks like this was fixed previously in 
r324. 
Am I missing something?

Original comment by marc.gravell on 5 Jun 2010 at 5:34

GoogleCodeExporter commented 8 years ago

Original comment by marc.gravell on 5 Jun 2010 at 5:35