search

DerwenAI / kglab

Graph Data Science: an abstraction layer in Python for building knowledge graphs, integrated with popular graph libraries – atop Pandas, NetworkX, RAPIDS, RDFlib, pySHACL, PyVis, morph-kgc, pslpython, pyarrow, etc.
https://derwen.ai/docs/kgl/
MIT License
574 stars 65 forks source link

Move setup.py functionality to poetry for pre-check and package build and release. #275

Closed ghost closed 1 year ago

ghost commented 2 years ago

I'm submitting a

[x] feature idea to research and discuss

This is split from https://github.com/DerwenAI/kglab/issues/272

Current Behaviour:

Investigate and review the implication of changing the existing use of setup.py and using poetry instead for pre-check, package build, and release.

One thing I am not at all clear on is the documentation building for KGLab, and how that will need to be managed in a poetry env / process.

ceteri commented 1 year ago

hi @jake-biolexis , i'm doing an initial impl on pyproject.toml since it will be required for the next update of pip

my impl could probably use some help :)

jake-aft commented 1 year ago

@ceteri i do not have permission to publish to test-pipy on kglab.

publishI am happy to assume that the poetry publish will work, as I think a lot of people use it.

Using poetry build I am getting builds at ~50 K with exclude of the rdf dir Does that seem small to you or expected?

➜ kglab git:(poetry_build) ✗ ls -lh dist
-rw-r--r-- 1 jake staff 51K Dec 3 16:35 kglab-0.1.1a3-py3-none-any.whl -rw-r--r-- 1 jake staff 45K Dec 3 16:35 kglab-0.1.1a3.tar.gz

jake-aft commented 1 year ago

Included in PR - https://github.com/DerwenAI/kglab/pull/300

jake-aft commented 1 year ago

@ceteri I think this can be closed as it should be addressed in #300 ?