search

DesCamat / range-seek-bar

Automatically exported from code.google.com/p/range-seek-bar
0 stars 0 forks source link

Added rounding factor and color selection #7

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Added some small enhancements:

- Selection of color (setActiveColor()) and two color constants or ICS-blue and 
pre-ICS orange. Being able to change the color dynamically should also allow to 
add color effects, e.g. fading to red for smaller values etc.

- Added a rounding factor (setRoundingFactor()) to allow of discrete values, 
eg. 0.5 steps

Thanks for the great widget!
Bachi

Original issue reported on code.google.com by bachi.in...@gmail.com on 16 Mar 2012 at 5:01

Attachments:

GoogleCodeExporter commented 9 years ago 
(sorry, not a defect of course, pls. change the type)

Original comment by bachi.in...@gmail.com on 16 Mar 2012 at 5:04

GoogleCodeExporter commented 9 years ago 
(and also I don't know whether these small changes qualify me for an @author 
entry, feel free to remove it if not ;-)

Original comment by bachi.in...@gmail.com on 16 Mar 2012 at 5:05

GoogleCodeExporter commented 9 years ago 
Hi Bachi,

sorry for the delay. Thanks for the enhancements! I totally agree with your 
color handling improvements, but have a question regarding the rounding factor. 
As I pointed out in a comment to issue #1, introducing step size (or your 
rounding factor) changes the behaviour of this widget in a way, so that the UI 
state (the screen position of the thumbs) do not represent its internal state 
(the selected values) anymore. This might confuse the user.

But maybe its only me thinking this is a problem. I'd love to have some voting 
mechanism on code.google.com. Anyone interested in commenting with "+1" or "-1" 
regarding this issue?

Original comment by tittel@kom.e-technik.tu-darmstadt.de on 21 Mar 2012 at 9:35

GoogleCodeExporter commented 9 years ago 
Well, what the rounding does is simply round the returned values, not the 
internal ones that are used for calculating the handle positions. So there's no 
change in the dragging smoothness. So, it's not really a step size, just a 
small convenience feature.

Cheers - Bachi

Original comment by bachi.in...@gmail.com on 14 Apr 2012 at 7:16