DesarrolloAntonio / Shiori-Android-Client

Android app client for Shiori
Apache License 2.0
132 stars 3 forks source link

[BUG] Not all tags automatically load from web instance of Shiori #40

Closed erat-verbum closed 5 months ago

erat-verbum commented 6 months ago

Bug Description If I open the android app and click on the filter icon at the top right, not all the tags show up in the slide-up card.

However, if I scroll through all the bookmarks before selecting the filter, then all the tags show up.

Steps to Reproduce Steps to reproduce the behavior:

  1. Close the app
  2. Open the app and immediately tap the filter button in the top right-hand corner.
  3. Observe that not all the tags show up.
  4. Now close the filter and scroll to the bottom of all the bookmarks
  5. Open up the filter again and you will see all of the tags appear

Expected Behavior All the tags should appear when tapping the filter button, without needing to scroll through all the bookmarks.

Screenshots Screenshot_20240506-133052

Device Information

Additional Context

Monirzadeh commented 6 months ago

thinking about this situation you have 6000 bookmarks in shiori do you expect have all of them offline in app for the first time?(that take time for big database to get all of them) or just expect to have all tags available on shiori (even if you don't have that article offline yet)? currently apps show tags for what is available offline.

in-principio commented 6 months ago

That's a good point.

I think, from a user's perspective, if they have reached 6000 bookmarks, then tags would be pretty much the only way of navigating all of those bookmarks.

So, minimally, I think all the tags should be available offline. And then, when a tag is selected, the associated articles can be downloaded.

erat-verbum commented 5 months ago

I can confirm that this is now working for me. Thank you!